Fixed [BUG 3.6.4] SQL error with roms with dupl. crc

Bugs are now stored in a bug tracker application. Click on the "Support/Bug reports" link above.

Moderator: Wanderer

Locked
Tester

Fixed [BUG 3.6.4] SQL error with roms with dupl. crc

Post by Tester »

Hello,

I did start a new thread because I don't want a discussion about using no-Intro.

I have two DATs, one for GoodGBA 3.14 and one for GoodGen 3.21,
the DAT files working and creating databases without problems,
but when I add the rom folder I get a SQL error

multiple rows in singleton select
At procedure 'P_UPDATEROMID' line: 11, col:3
At procedure 'P_LOADFILES' line: 82, col: 1
multiple rows in singleton select
GDS Code: 335544652 - SQL Code: -811 - Error Code: 332.

I found the reason, some files have the same CRC but a different SHA1

here are the parts with the dublicated CRCs in the DATs

---------------------------------------------- GoodGen 3.21 ----------------------------------------------

clrmamepro (
name "Sega - Mega Drive, Genesis (Good 3.21)"
)


game (
name "Rock n' Roll Racing, alpha"
rom ( name "Rock n' Roll Racing - v15_alpha_r6 (Hack).bin" size 2097152 crc 4c9a6a33 md5 ee4c14b9f112426feb09ac77c34b453c sha1 92ab0cf5a8eb26b778a5dd9a99109b03903d34c7 )
rom ( name "Rock n' Roll Racing - v15_alpha_r6-p1fullsw (Hack).bin" size 2097152 crc cfff8237 md5 a3a1b3cde3faf7f656cfc9fc35f4dcef sha1 c13ccf68ba269b7010db51148b74c9f106566d95 )
rom ( name "Rock n' Roll Racing - v15_alpha_r6-p2fullsw (Hack).bin" size 2097152 crc cfff8237 md5 7e5467f1553c76bb563252c5f7219238 sha1 d7229e0a1047d98dea57e7ae69a220547e21c862 )
rom ( name "Rock n' Roll Racing - v15_alpha_r7 (Hack).bin" size 2097152 crc b280748c md5 8f0c169b27355ab1f43ecf5ce921c10c sha1 56a1df4b161cabc904b8b33e0aa6562e05605e6d )
rom ( name "Rock n' Roll Racing - v15_alpha_r7-p1fullsw (Hack).bin" size 2097152 crc b280748c md5 9775c6d72eb1c9eeeda7388a9c1c1007 sha1 d1489bc637713bc14830db8e3a04c99616bb6e94 )
rom ( name "Rock n' Roll Racing - v15_alpha_r7-p2fullsw (Hack).bin" size 2097152 crc b280748c md5 4ae92a0cf03655fdf0c44762d85e914a sha1 a671537261545545a7345a7ec6e7293ceacf3100 )
rom ( name "Rock n' Roll Racing - v15_alpha_r7-p3fullsw (Hack).bin" size 2097152 crc b280748c md5 81c975b707b8d844a05585d8f31adbfd sha1 6be88c8e3ae1c8a4108f824bb2409cdb985ad004 )
)

game (
name "Rock n' Roll Racing, Tournament Edition"
rom ( name "Rock n' Roll Racing - Tournament Edition (6 Cars Demo) (Hack).bin" size 3234690 crc 7bc11978 md5 cf3d432396c5aa440844b48616dee3ba sha1 52c59d8f3c429abf62031b3ef192cd258019fc62 )
rom ( name "Rock n' Roll Racing - Tournament Edition (v04b-p1_fullsw) (Hack).bin" size 2097152 crc 3567ee39 md5 d448544199c5ccd04c76fe209382301f sha1 47369c35882f6bf320106e3edaea1b9bf1072d63 )
rom ( name "Rock n' Roll Racing - Tournament Edition (v04b-p3_fullsw) (Hack).bin" size 2097152 crc 3567ee39 md5 c0a86cdaecef0c102736bd28e4c93683 sha1 483b116b7a84b12bc66ae1218b8933ee9b75da7f )
rom ( name "Rock n' Roll Racing - Tournament Edition (v04b-team1) (Hack).bin" size 2097152 crc 3567ee39 md5 2af43765655d44477545c054a2fa2f73 sha1 1d969b9ba655dbde273fc2c151be472a754acccd )
rom ( name "Rock n' Roll Racing - Tournament Edition (v04b-team2) (Hack).bin" size 2097152 crc 3567ee39 md5 e3a98c051f93165c99046683427459cd sha1 4bcd8560b1bd2b1e0c748af57e880426d8ca3d6e )
rom ( name "Rock n' Roll Racing - Tournament Edition (v05g-p1_fullsw) (Hack).bin" size 2097152 crc e178d404 md5 166af89d2339cc5cb06cb0869a0c4050 sha1 3445e7d71c2cfe6d03a46f4292ff9f1e97b4d1d0 )
rom ( name "Rock n' Roll Racing - Tournament Edition (v05g-p3_fullsw) (Hack).bin" size 2097152 crc e178d404 md5 05c22070e38ec540ee23204c083ea219 sha1 6dfb0d2a78d519ed3033324f942d502560cec979 )
rom ( name "Rock n' Roll Racing - Tournament Edition (v05g-team1) (Hack).bin" size 2097152 crc e178d404 md5 1633a88c4ee7a72df3d7013d3c462e29 sha1 c576a2b2c65957be9a9ad8bf4748d7596db1a6a3 )
rom ( name "Rock n' Roll Racing - Tournament Edition (v05g-team2) (Hack).bin" size 2097152 crc e178d404 md5 3501974746b6e5dde32a8f3cd67d0e73 sha1 405d38a4e4adc1619b90b4e80be9793c327dd68e )
rom ( name "Rock n' Roll Racing - Tournament Edition (v06b) (6players-team1) (Hack).bin" size 2097152 crc 238d7989 md5 1280ac292274bf6c359033a8a0034abf sha1 1aee28f9585926dee848559352004f5a7ba0aeeb )
rom ( name "Rock n' Roll Racing - Tournament Edition (v06b) (6players-team2) (Hack).bin" size 2097152 crc 238d7989 md5 496730f225a91cce945fb457085f2c21 sha1 526bd7af0def1aa9f00612fd68ca0048dbdfa320 )
rom ( name "Rock n' Roll Racing - Tournament Edition (v06b) (6players-team3) (Hack).bin" size 2097152 crc 238d7989 md5 9a06a6df3ae5da4655cc9b4b1718c38f sha1 9a8945625e061b7a7cd17939ae5b72d0d58a1569 )
)

---------------------------------------------- GoodGBA 3.14 ----------------------------------------------

clrmamepro (
name "Nintendo - Game Boy Advance (Good 3.14)"
)

game (
name "Meet the Robinsons"
rom ( name "Meet the Robinsons (E) (M6) [f_4].gba" size 8388608 crc 4e3c9d3f md5 c35d25161f7cbba08fe027fed5ac972f sha1 dee7c616b6362d8e89b6c86ca1fc0b656c09e053 )
rom ( name "Meet the Robinsons (E) (M6) [f_5].gba" size 8388608 crc 2f6ceeed md5 4c49329c789685d39cd9d48cdbd85ebc sha1 b16832220d79286d5fad5e20b210b413b0b00ef5 )
rom ( name "Meet the Robinsons (E) (M6).gba" size 8388608 crc df3e58d3 md5 59aba4bba551aa20bf7726eba3af13fe sha1 1b5376d0c0b64973d74434a3a7388eeba3005aab )
rom ( name "Meet the Robinsons (U) [f_4].gba" size 8388608 crc fc98748e md5 65dff45a7a35f6f69811bd9405c47387 sha1 0b9e38ac467646205167bb440fe22036f57197b3 )
rom ( name "Meet the Robinsons (U) [f_5].gba" size 8388608 crc 16c54da0 md5 4a68177c1e6080d9187b9f8dd4668031 sha1 164eca1024d6a0f5e90cd4a866cc04d5c4c24f68 )
rom ( name "Meet the Robinsons (U) [hI].gba" size 8388608 crc 3787c93c md5 28eaa16adcb92afba84f4e8284c65cbf sha1 d3754a54ab51c85caedc639a1084814970574963 )
rom ( name "Meet the Robinsons (U) [hI][f_4].gba" size 8388608 crc fc98748e md5 48c60470cf203568ec923ef8ac360338 sha1 0771dde8493d601223f9ef7fbb49bdd09445da6f )
rom ( name "Meet the Robinsons (U) [hI][f_5].gba" size 8388608 crc 16c54da0 md5 06f8d169e0e19c261c89c28a230296eb sha1 8aa68cd9f27924e7aeeee5f7fa3b0203ba37e48e )
rom ( name "Meet the Robinsons (U).gba" size 8388608 crc 3787c93c md5 cfbf47949426a8f44ecdc832d06d09a9 sha1 58ad2756f1985430e1ef605bdcba82564099a030 )
)

game (
name "Petz Vet [Good]"
rom ( name "Petz Vet (U) [f_4].gba" size 8388608 crc b73771f7 md5 0bcdadab4ef9ed07477fd806cd7e277a sha1 04e0380ed20e764901493d9a49d66f2ca043e3e4 )
rom ( name "Petz Vet (U) [f_5].gba" size 8388608 crc 742d92ec md5 415d72cf996fd8af182aa3e41be4c22e sha1 dabd303945aea30a380afd6f9f9fdd5a3ec926cc )
rom ( name "Petz Vet (U) [hI].gba" size 8388608 crc 1dbf4d3d md5 978ed70eca1b3b6742f2b0b6c79bd4ac sha1 5c4d99f9d8589a2d49bfb01c77395fb4ffb1eb5c )
rom ( name "Petz Vet (U) [hI][f_4].gba" size 8388608 crc b73771f7 md5 a9c6589d1c77119595aad82ce572b07c sha1 3bf6d724727455cacc7a1e791a679b0b55da984e )
rom ( name "Petz Vet (U) [hI][f_5].gba" size 8388608 crc 742d92ec md5 1426614387eadd1cd28be9e8e3cb85ef sha1 d68a631a1def719b8665479fea9b78bf89226946 )
rom ( name "Petz Vet (U).gba" size 8388608 crc 1dbf4d3d md5 43cf1c2b7601db441295f12c538ae3a3 sha1 9755a6eaf65d10131e591c4c75b9c77554cd1dad )
)
Tester

Re: SQL error when add folder with roms with dupl. crc

Post by Tester »

Here are the roms and dats to reproduce

http://www.mediafire.com/?6vu8fcadqbfo5
User avatar
RomCenter
Author
Author
Posts: 1520
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: SQL error when add folder with roms with dupl. crc

Post by RomCenter »

I had a look at that and I'm currently working on a fix.
This is a quite heavy fix, touching deep processes because it involves calculating a sha1 when crc/size are identical.
I already created the sha1 plugin and I'm now adding the new process.
It will be released as a 3.7 version.

Thank you for your message and files.
Eric - RomCenter developer
Report bugs here.
User avatar
RomCenter
Author
Author
Posts: 1520
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: [FIXED] [BUG 3.6.4] SQL error with roms with dupl. crc

Post by RomCenter »

Fixed in 3.7.0
Eric - RomCenter developer
Report bugs here.
User avatar
The Wizard of DATz
PacMan
PacMan
Posts: 5
Joined: Wed Nov 14, 2012 8:22 pm
Contact:

Re: Fixed [BUG 3.6.4] SQL error with roms with dupl. crc

Post by The Wizard of DATz »

I did a test for goodGBA and it is OK
Locked