Delayed [BUG 3.54] Unzipped duplicated roms not renamed

Bugs are now stored in a bug tracker application. Click on the "Support/Bug reports" link above.

Moderator: Wanderer

Locked
wout25

Delayed [BUG 3.54] Unzipped duplicated roms not renamed

Post by wout25 »

I've got 2 folders containing identical roms (nds).

They have bad names, so I repair the roms in 1 folder. No problem here.

I want to rename de roms in the second folder too, without deleting them.
My UNchecked "Fix parameters" are:

-Remove useless files
-Remove useless roms
-Unzip en rezip

Code: Select all

log:

Fix incorrect rom files
TreeView selection : 1
Rom mode : split
Bios mode : split
Sample mode : merged
Plugin : arcade.dll
Threads : 10
Green games : 92, yellow games : 0, red games : 4558
--->Rezip: disabled
--->Test archives
  No files to test
Done. Files tested: 0 in 0h 0m 0s
--->Rename files
  No files to rename
Done. Files renamed: 0 in 0h 0m 0s
--->Fix samples: disabled
--->Remove roms: disabled
--->Rename roms
Done. Roms renamed: 0 in 0h 0m 0s
--->Import missing roms
  No roms to import
Done. Roms imported: 0 in 0h 0m 0s
--->Create dummies: disabled
--->Create ghost games: disabled
--->Remove roms: disabled
--->Remove files: disabled
--->Fix samples: disabled
--->Remove zip comments
Done. Zip comments removed: 0 in 0h 0m 0s
--->End fixing
yellow games: 0
It's as if it doesn't see the yellow games when there duplicates and hence doesn't fix their name.

any thoughts?
w.

PS: Romcenter is a great tool! Much respect.

User avatar
RomCenter
Author
Author
Posts: 1519
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: possible bug

Post by RomCenter »

I tried as you said, but can't reproduce the problem.
Did you correctly select the second folder before repairing ?

Green, yellow and red counter are global status of database. It reports how many games are complete, incomplete or missing, as appearing under the datafile node. It doesn't care if one have bad name.
Eric - RomCenter developer
Report bugs here.

wout25

Re: possible bug

Post by wout25 »

ah, so if I understand you correctly, Romcenter doens't change names of yellow and red roms (anymore, because version 2.7 did)?

I'm experiencing this problem since I updated to version 3.4

What I did now was close 1 rom path, fix the roms and added the second rom path again.
Now the duplicates are yellow and have the correct name.

I still think TC should change the names of yellow roms.

kind regards,
w.

User avatar
RomCenter
Author
Author
Posts: 1519
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: possible bug

Post by RomCenter »

Rc does change names of red and yellow files.

What I don't understand is the duplicate files. If I try to reproduce your problem, rc doesn't report duplicates on my pc.
Could you be more precise and describe me an example with two files (and maybe a screenshot could help. You can add pic in threads).
Eric - RomCenter developer
Report bugs here.

wout25

Re: possible bug

Post by wout25 »

Ok, I made some screenshots.

First of all, my preferences:
Image

Now This is the situation before fixing (splitscreen):
Image

This is the situation after fixing (splitscreen):
Image

Now, the duplicate "some_rom.nds" doesn't get renamed...
It's as if the "duplicated" state prevents it from being renamed.

I hope you can recreate this situation, or tell me I'm not thinking straight.
To my recollection, romcenter 2.7 didn't have this problem.

regards,
w.

User avatar
RomCenter
Author
Author
Posts: 1519
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: possible bug

Post by RomCenter »

Ok, I will try again. Thank you.
Eric - RomCenter developer
Report bugs here.

wout25

Re: possible bug

Post by wout25 »

Any news on this?

User avatar
RomCenter
Author
Author
Posts: 1519
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: possible bug

Post by RomCenter »

Not yet, I'm working on multithreaded repair processes currently.
But I will give a try to your problem.
Eric - RomCenter developer
Report bugs here.

User avatar
RomCenter
Author
Author
Posts: 1519
Joined: Fri Sep 28, 2001 12:34 pm
Location: France
Contact:

Re: possible bug

Post by RomCenter »

I give a try again on this problem.
I reproduce your behaviour with unzipped roms.

Roms in folder 1 can be fixed.
Roms in folder 2 are flagged 'duplicated' and are not renamed. It is normal, as these roms are duplicates, rc will remove it if you check the ''Remove useless files".

Maybe more 'duplicates' options are needed, but this is a point I will address when I build 'dedicated folders' feature.
Eric - RomCenter developer
Report bugs here.

Locked